I rebased Jason's branch against master and added a simple tweak to reconcile it with the newer code that fetches actor.usr_circ_history objects.
For testing, I used the concerto test data and mocked up some circ history data with the admin user in psql like so:
insert into action.usr_circ_history (usr,xact_start,target_copy,due_date,checkin_time,source_circ) select 1,xact_start,target_copy,due_date,checkin_time,id from action.circulation;
I didn't bother changing the circ user on those circs, but I did enable the user setting for recording circ history.
In master, using Download CSV against these takes about 2 minutes and produces an empty CSV file. With the bugfix branch, it took about 5 seconds for almost 500 entries. Thanks Jason!
I rebased Jason's branch against master and added a simple tweak to reconcile it with the newer code that fetches actor.usr_ circ_history objects.
For testing, I used the concerto test data and mocked up some circ history data with the admin user in psql like so:
insert into action. usr_circ_ history (usr,xact_ start,target_ copy,due_ date,checkin_ time,source_ circ) select 1,xact_ start,target_ copy,due_ date,checkin_ time,id from action.circulation;
I didn't bother changing the circ user on those circs, but I did enable the user setting for recording circ history.
In master, using Download CSV against these takes about 2 minutes and produces an empty CSV file. With the bugfix branch, it took about 5 seconds for almost 500 entries. Thanks Jason!
Top 3 commits from collab/ phasefx/ lp1208875
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/collab/ phasefx/ lp1208875
I'm willing to push it to master but would like just one more sanity check from someone. Thanks!