Comment 2 for bug 1145213

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

This isn't limited to prefixes and suffixes and is actually two separate issues, both of which are fixed by the patch at user/rogan/lp11452113_bib_merge

Testing I did ....

bib 250 - new lead
org 4 acn 'F Cline' copy 1

bib 251 - merged from target
org 5 acn 'F Cline' copy 2
org 6 acn 'JF Cline' copy 3
org 4 acn 'F Cline' copy 4

copy 2 ACN moved from 251 to 250 correctly
copy 3 ACN moved from 251 to 250 correctly
copy 4 moved from it's ACN to the ACN of copy 1 correctly
bib 251 deleted

acn of copy 2 not deleted (correct)
acn of copy 3 not deleted (correct)
acn of copy 4 note deleted (incorrect)

All of these had -1 for prefix and suffix.

Looking at the merge assets function it looks like the logic to move assets assumes that it will be able to move and never evaluates for deletion. I think the ticket report on this is incorrect because it never deletes the volume (which is still a bug).

However, it also does not pay attention to prefixes (which is a separate problem).

With the patch the volume correctly deletes. I also added a prefix to the org 4 bib 251 record, and post patch it no longer moved over to 251 since the prefix differs now (it was moved over incorrectly before).