Prevent hold activation date being a date in the past

Bug #985957 reported by Jennifer Pringle on 2012-04-20
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Evergreen 2.0.10
OpenSRF 2.0.1
Postgress 8.4
OS: Ubu Lucid

When a patron suspends a hold in the OPAC they are able to enter a date that has already passed as the activation date. The system accepts this date and never activates the hold. The hold can only be activated manually by either the patron or a staff member.

This behaviour of allowing a past date is present in the TPac for 2.2 as well.

The staff client recognizes past dates and does not allow staff to set a past date.

Jason Stephenson (jstephenson) wrote :

I am removing the "opac" tag because this will not be fixed in JSPAC at this point. It is still a valid issue for tpac and possibly kpac as well. (I've not looked at kpac, yet.)

tags: removed: opac
Jason Stephenson (jstephenson) wrote :

I plan to roll the fix for this into my fix for https://bugs.launchpad.net/evergreen/+bug/1076399 .

Should we mark this as a duplicate? I don't see much of a way to link bugs other than that.

Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
milestone: none → 2.4.0-alpha
Jason Stephenson (jstephenson) wrote :

Not going to do this one at this time. It is a tad more complicated than messing with expiration dates, since we'll likely need to interact with the user.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
importance: Low → Wishlist
importance: Wishlist → Low
importance: Low → Wishlist
Ben Shum (bshum) on 2013-03-03
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum) on 2013-03-17
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum) on 2013-04-27
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Dan Wells (dbw2) on 2013-06-12
Changed in evergreen:
milestone: 2.5.0-m1 → none
Garry Collum (gcollum) wrote :

This behavior is still true in TPac 3.0.7 and current master. The webclient also allows staff to input past activation dates.

tags: added: webstaffclient
Jennifer Pringle (jpringle-u) wrote :

Confirming this is still an issue in 3.1.7

Terran McCanna (tmccanna) wrote :

Confirmed still an issue in 3.2.3

tags: added: opac
removed: tpac
Suzanne Paterno (paterno) wrote :

The OPAC also allows values that are not dates or even numbers. Dates that are not valid dates (outside the range of months, days or years) area also accepted.

Suzanne Paterno (paterno) wrote :

I wrote a new Javascript function to holds_validation.js to check that the date entered is a valid date in the future. Will post fix shortly.

Michele Morgan (mmorgan) on 2019-08-26
Changed in evergreen:
milestone: none → 3.3.4
milestone: 3.3.4 → 3.4-beta1
Galen Charlton (gmc) on 2019-09-06
Changed in evergreen:
importance: Wishlist → Medium
Galen Charlton (gmc) on 2019-09-11
Changed in evergreen:
milestone: 3.4-beta1 → 3.4-beta2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers