Activating an expired hold cancels the hold

[Jason Stephenson]

OpenSRF: master/2.1.1
Evergreen: master 20121028 && 20121106
O/S: Ubuntu Precise (12.04.1)
PostgreSQL: 9.1 && 9.2

If a patron suspends a hold and then reactivates it after the hold expiration date, the hold targeter cancels the holds with cancel_cause 1: Untargeted expiration.

This is easy to reproduce: Place a hold. Suspend it. Change the expiration date to a date in the past. Activate the hold after the expiration date. Wait for the hold targeter to run.

My suggestion is that suspending/deactivating a hold should clear the expiration date. Reactivating a hold should reset the expiration date from the date of activation. As a bonus, it should be made impossible for a patron to set an expiration date on a hold while it is suspended. Or to set a reactivation date on one that isn't suspended. (Not sure if the latter is currently possible.) This probably cannot be implemented well in TPAC without some JavaScript to manipulate the form fields.

[Jason Stephenson (jstephenson)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1076399

The last four commits:

a510c5a616598674b747e9b6894870874df58eea
3f3114e6016386b94597ebe84cf28b86c9b06007
43c453cefa0df2ccf7b882578a708776280088da
1187ee7f334a789d1df676effa9f486444fc80c0

The above also fixes https://bugs.launchpad.net/evergreen/+bug/893448 in master.

[Ben Shum (bshum)]

Seems to work for me. Picked to master. Thanks Jason!