Acq: attempting to set a fund's propagate to TRUE without rollover = TRUE fails without notice to user

[Tim Spindler]

Evergreen 2.2 Alpha 3
Evergreen 2.2 Beta

Click on save in creating a new fund and nothing happens.

***UPDATE***

With some teaching from Dan Scott, it's been discovered that the problem was that we selected "rollover", but didn't select "propagate".

This lead to:

osrfsys.log:open-ils.pcrud 2012-04-09 12:45:48 [ERR :5775:oils_sql.c:2265:1333880709110556] open-ils.pcrud ERROR inserting acq::fund object using query [INSERT INTO acq.fund (id,org,name,year,currency_type,code,rollover,propagate,active,balance_warning_percent,balance_stop_percent) VALUES (DEFAULT,4,'test fund',2013,'USD','tfund','t','f','t',0,0);]: 0 ERROR: new row for relation "fund" violates check constraint "acq_fund_rollover_implies_propagate"

Easy enough, for someone with access to the logs. Not so easy, however, for the end user who gets no error message at all, just sent back to the initial "Funds" interface.

So, the bug here, is the lack of an error message for this situation.

[Michael Peters (mrpeters)]

Tim,

Do your logs indicate anything? I'm thinking maybe database rollbacks, perhaps? Permission failure?

I just tested in a freshly installed master (from about 10AM today) and I was able to create a fund without issue. I also just checked my community 2.2 server, and all is well there, too. You're welcome to test there.

testing.evergreen.lib.in.us
Login: admin
Password: open-ils

-Mike

[Tim Spindler (tspindler-cwmars)]

Mike,

I tested this on the Indiana test server.

Tim

[Michael Peters (mrpeters)]

Tim and I have discovered that the problem was that we selected "rollover", but didn't select "propagate".

This lead to:

osrfsys.log:open-ils.pcrud 2012-04-09 12:45:48 [ERR :5775:oils_sql.c:2265:1333880709110556] open-ils.pcrud ERROR inserting acq::fund object using query [INSERT INTO acq.fund (id,org,name,year,currency_type,code,rollover,propagate,active,balance_warning_percent,balance_stop_percent) VALUES (DEFAULT,4,'test fund',2013,'USD','tfund','t','f','t',0,0);]: 0 ERROR: new row for relation "fund" violates check constraint "acq_fund_rollover_implies_propagate"

Easy enough, for someone with access to the logs. Not so easy, however, for the end user who gets no error message at all, just sent back to the initial "Funds" interface.

So, the bug here, is the lack of an error message for this situation.

[Jennifer Pringle (jpringle-u)]

This bug is still present on 2.4.0

[Tiffany Little (tslittle)]

Just tested on our 3.4.1 test system, and I can confirm this is still happening.

[Tiffany Little (tslittle)]

Since the angular acq administration work has been merged to master, I just tested this on a master system. When you attempt to add a fund with propagate=no, rollover=yes, the fund creation fails with a red toast message of "Failed to create new fund." Since the original bug report was for lack of an error message(or any action at all), I'm considering this as fixed in the new work. Marking as Won't Fix.