Acq: attempting to set a fund's propagate to TRUE without rollover = TRUE fails without notice to user

Bug #977280 reported by Tim Spindler on 2012-04-09
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Evergreen 2.2 Alpha 3
Evergreen 2.2 Beta

Click on save in creating a new fund and nothing happens.

***UPDATE***

With some teaching from Dan Scott, it's been discovered that the problem was that we selected "rollover", but didn't select "propagate".

This lead to:

osrfsys.log:open-ils.pcrud 2012-04-09 12:45:48 [ERR :5775:oils_sql.c:2265:1333880709110556] open-ils.pcrud ERROR inserting acq::fund object using query [INSERT INTO acq.fund (id,org,name,year,currency_type,code,rollover,propagate,active,balance_warning_percent,balance_stop_percent) VALUES (DEFAULT,4,'test fund',2013,'USD','tfund','t','f','t',0,0);]: 0 ERROR: new row for relation "fund" violates check constraint "acq_fund_rollover_implies_propagate"

Easy enough, for someone with access to the logs. Not so easy, however, for the end user who gets no error message at all, just sent back to the initial "Funds" interface.

So, the bug here, is the lack of an error message for this situation.

Michael Peters (mrpeters) wrote :

Tim,

Do your logs indicate anything? I'm thinking maybe database rollbacks, perhaps? Permission failure?

I just tested in a freshly installed master (from about 10AM today) and I was able to create a fund without issue. I also just checked my community 2.2 server, and all is well there, too. You're welcome to test there.

testing.evergreen.lib.in.us
Login: admin
Password: open-ils

-Mike

Tim Spindler (tspindler-cwmars) wrote :

Mike,

I tested this on the Indiana test server.

Tim

Michael Peters (mrpeters) wrote :

Tim and I have discovered that the problem was that we selected "rollover", but didn't select "propagate".

This lead to:

osrfsys.log:open-ils.pcrud 2012-04-09 12:45:48 [ERR :5775:oils_sql.c:2265:1333880709110556] open-ils.pcrud ERROR inserting acq::fund object using query [INSERT INTO acq.fund (id,org,name,year,currency_type,code,rollover,propagate,active,balance_warning_percent,balance_stop_percent) VALUES (DEFAULT,4,'test fund',2013,'USD','tfund','t','f','t',0,0);]: 0 ERROR: new row for relation "fund" violates check constraint "acq_fund_rollover_implies_propagate"

Easy enough, for someone with access to the logs. Not so easy, however, for the end user who gets no error message at all, just sent back to the initial "Funds" interface.

So, the bug here, is the lack of an error message for this situation.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
description: updated
tags: added: acq
summary: - save funds
+ Acq: Attempting to save certain fund configurations fails without
+ notice to user
summary: - Acq: Attempting to save certain fund configurations fails without
- notice to user
+ Acq: attempting to set a fund's propagate to TRUE without rollover =
+ TRUE fails without notice to user
description: updated
Jennifer Pringle (jpringle-u) wrote :

This bug is still present on 2.4.0

tags: added: silentfailure
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers