Edit, then Create button creates a new item in all cases

[Dmagick]

EG 2.1.1

When considering to add an item in Holdings Maintenance, two options are provided to the staff member:
1) Create
2) Edit, then Create

When choosing the second option, the user is taken to a screen to edit the said item. At this point, this item being edited is considered to be in flux, therefore temporary and not added to the holdings.

If the user changes their mind and decides not to continue with the edit and then selects the red X to kill the screen, or if the button Close is selected, an item is created anyway.

In other words, both available buttons Modify/Create Copies and Close in the item edit screen produce the same result.

[Elaine Hardy (ehardy)]

We consider this a very serious bug. An unnecessary item is created that has to be deleted. If it is not deleted because a cataloger did not realize it was created, confusion and problems with stats could be created.

Elaine Hardy

[Steven Chan (schan2)]

Here is a fix for the problem.

It also fixes https://bugs.launchpad.net/evergreen/+bug/806585, which is a duplicate, but there a comment was posted saying the problem does not exist on v2.1 and therefore the bug status was changed to 'wontfix'. However, we experience the problem after upgrading from 1.6 to 2.2 at catalogue.bclibraries.ca.

The patch also includes a fix for https://bugs.launchpad.net/evergreen/+bug/644753, check for duplicate barcode during a create session in copy/volume editor. See comments in the patch for further details.

Including a DCO for the patch, since it is more than a one-liner and includes a new behaviour.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Steven Chan, <email address hidden>

[Ben Shum (bshum)]

Had to turn off unified volume editor to see the button that's being described here. But tested and seems to be working to avoid creating a copy if one leaves the copy editor after using "Edit, then Create".

Some minor branch conflicts that I fixed to apply the patch to master.

Sign-offs:

For Master: user/bshum/lp949249_master

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp949249_master

For 2.2: user/bshum/lp949249_2_2

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp949249_2_2

[Bill Erickson (berick)]

Merging the master/rel_2_3 version. Thanks!

[Ben Shum (bshum)]

Marking as "won't fix" for 2.2 because we are outside the 2.2 support timeframe for non-security bug fixes.