Comment 1 for bug 869338

Revision history for this message
Dan Scott (denials) wrote :

Quick comments as I merged the code to a local branch for review:

1) There is some code duplication that could be reduced; I would like to see something like a commonly defined "can_bib_source_have_copies(bib_id)" JS function that just returns true or false.

2) Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/config.pm should be taught about the new column on config.bib_source