Comment 9 for bug 851000

Revision history for this message
Dan Wells (dbw2) wrote :

I have been looking over this branch, and I do not think the present solution does all that is required. LOST items, by default, are supposed to stay lost until they arrive at their home org unit. This is accomplished by storing the lost status in the transit and restoring it when it arrives at its home. The present branch appears to remove this feature.

It seems like what we want to do instead is run the 'checkin_handle_lost' method both where it is now (in master) and also in the 'transit' branch of do_checkin ( branch starting with '} elsif( $self->transit ) {' ), checking for the LOST status after the pre-transit status has been restored (and the subsequent event has been overridden).

Does this make sense? I am happy to work out a branch along these lines if requested, but I am also happy to let the current parties continue owning this bug if they want to keep working on it.

Thanks,
Dan