Comment 4 for bug 851000

On 11/16/2011 10:14 PM, Jason Stephenson wrote:
> What I found tonight is it seems to be an interplay between the void
> lost billings on checkin and lost items usable at checkin setting. Both
> of these have to be on at the owning library (or its ancestors) for the
> billings to be voided when the copy is checked in at a library that
> doesn't own the copy.--I think this is a bug, and I'll explain my
> reasons.
>
> In looking at the code in master, the check for the lost usable at
> checkin setting's value is done in O::A::Circ::Circulate.pm at about
> line 3304. If that is false, and we're not at the library that owns the
> copy, we simply log a message to say that we're not changing the status
> to avoid problems when it goes home.
>
> Following that is an elsif that checks for void lost billings. This only
> fires if the above check "fails."
>
> Thus, it seems if we lost billings to clear without the copy going home,
> we set both the void lost billings and lost items usable at checkin ou
> settings.

This all sounded very familiar, so I got in the way-back machine...

http://libmail.georgialibraries.org/pipermail/open-ils-dev/2009-March/004380.html

In some very old code, I believe these comments detail what you're
describing, circa line 2124:
    http://svn.open-ils.org/trac/ILS/changeset/12548

When I birthed LOST_IMMEDIATELY_AVAILABLE, I didn't consider the
ramifications, and we were never faced with it.

I'm not sure that this will help remedy the situation, but it may be the
point where the code started causing this issue.