Minor style/consistency suggestion... cuddle the else's. For example
if ($is_renew) { $method = 'open-ils.circ.renew'; } else { $method = 'open-ils.circ.checkout.full'; }
--- if ($is_renew) { $method = 'open-ils.circ.renew'; } else { $method = 'open-ils.circ.checkout.full'; } ---
With that and a squash, I think the branch is ready to go.
Minor style/consistency suggestion... cuddle the else's. For example
if ($is_renew) { circ.renew' ; circ.checkout. full';
$method = 'open-ils.
}
else {
$method = 'open-ils.
}
--- circ.renew' ; circ.checkout. full';
if ($is_renew) {
$method = 'open-ils.
} else {
$method = 'open-ils.
}
---
With that and a squash, I think the branch is ready to go.