I am not sure if curr_new_amt is correct in all cases. It will be correct in the case where it is set to allocated amount. It might need to be orig_allocated_amt in other cases.
I do not know what the logic is trying to do when it checks for
IF old_remaining > 0 THEN
Liam
On Feb 25, 2014, at 9:30 AM, Bill Erickson <email address hidden> wrote:
> Exactly! That's where I ended up, too. I should check my email more
> frequently ;) -- Ditto curr_new_amt for the destination fund allocation.
>
> I've pushed a fix to my pgtap test and the stored procedure to the same
> branch. The pgtap test now passes. A simpler transfer appears to work
> as well. Further testing appreciated.
>
>
> ** Also affects: evergreen/2.5
> Importance: Undecided
> Status: New
>
> ** Also affects: evergreen/2.4
> Importance: Undecided
> Status: New
>
> ** Changed in: evergreen/2.5
> Milestone: None => 2.5.4
>
> ** Changed in: evergreen/2.4
> Milestone: None => 2.4.7
>
> ** Changed in: evergreen
> Milestone: None => 2.6.0-beta1
>
> ** Tags added: pullrequest
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/800478
>
> Title:
> Acquisitions - Funds transfer always transfers entire fund, not
> specified amount
>
> Status in Evergreen - Open ILS:
> Confirmed
> Status in Evergreen 2.4 series:
> New
> Status in Evergreen 2.5 series:
> New
>
> Bug description:
> v. 2.05. Fund Transfer Problem: (Admin-Server Administration-Acquisitions-Funds-Fund Details for any fund-Transfer Money) When you transfer an amount from one fund to another it doesn't matter what amount you input, the entire fund is transferred.
> Confirmation from Sally Fortin, Equinox:
> Yes, I see a bug. When I transfer money from one fund to another, the amount transferring is not the amount that I specified but the entire original amount that was placed in the fund into another fund.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/800478/+subscriptions
I am not sure if curr_new_amt is correct in all cases. It will be correct in the case where it is set to allocated amount. It might need to be orig_allocated_amt in other cases.
I do not know what the logic is trying to do when it checks for
IF old_remaining > 0 THEN
Liam
On Feb 25, 2014, at 9:30 AM, Bill Erickson <email address hidden> wrote:
> Exactly! That's where I ended up, too. I should check my email more /bugs.launchpad .net/bugs/ 800478 Acquisitions- Funds-Fund Details for any fund-Transfer Money) When you transfer an amount from one fund to another it doesn't matter what amount you input, the entire fund is transferred. /bugs.launchpad .net/evergreen/ +bug/800478/ +subscriptions
> frequently ;) -- Ditto curr_new_amt for the destination fund allocation.
>
> I've pushed a fix to my pgtap test and the stored procedure to the same
> branch. The pgtap test now passes. A simpler transfer appears to work
> as well. Further testing appreciated.
>
>
> ** Also affects: evergreen/2.5
> Importance: Undecided
> Status: New
>
> ** Also affects: evergreen/2.4
> Importance: Undecided
> Status: New
>
> ** Changed in: evergreen/2.5
> Milestone: None => 2.5.4
>
> ** Changed in: evergreen/2.4
> Milestone: None => 2.4.7
>
> ** Changed in: evergreen
> Milestone: None => 2.6.0-beta1
>
> ** Tags added: pullrequest
>
> --
> You received this bug notification because you are a bug assignee.
> https:/
>
> Title:
> Acquisitions - Funds transfer always transfers entire fund, not
> specified amount
>
> Status in Evergreen - Open ILS:
> Confirmed
> Status in Evergreen 2.4 series:
> New
> Status in Evergreen 2.5 series:
> New
>
> Bug description:
> v. 2.05. Fund Transfer Problem: (Admin-Server Administration-
> Confirmation from Sally Fortin, Equinox:
> Yes, I see a bug. When I transfer money from one fund to another, the amount transferring is not the amount that I specified but the entire original amount that was placed in the fund into another fund.
>
> To manage notifications about this bug go to:
> https:/