Comment 8 for bug 793550

Good call, Dan!

I have pushed another commit on my branch that addresses most of your concerns:

I have moved the logic to check if the circ transaction can be closed to its own utility function in OpenILS::Application::Circ::CircCommon. This potentially consolidates the logic in one place in case we need to use it elsewhere.

I have also added a check for checkin_time being set on the transaction. It turns out that Dan's scenario of a MAXFINES book being checked in then paid did not set xact_finish with the old logic.

I am not going to touch _check_open_xact() at this time. I'm not entirely clear on its purpose at the moment, and the code in branch addresses this bug. If it turns out that _check_open_xact() needs changing, that could be handled in another bug, or tacked onto this one if it is still open.