Comment 7 for bug 741788

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Hello, I've tried rebasing this patch to master and tested it a little bit. There were quite a few changes to the marc_stream_editor since Galen created his patch.

The install bits look like they worked.
oils_header.pl and marc_stream_importer.pl were installed in the bin dir.
marc_stream_importer.conf.example was installed in the conf dir.

I'm not able to test the functionality of the marc_stream_importer.pl script, but it appears to not have syntax errors. I can view the built in help screens.

I would agree that storing the credentials in the config file would be best, to prevent an upgrade from wiping out edits made to the script.

The script now looks for /openils/conf/marc_stream_importer.conf as the default location for the config file, instead of in /openils/bin, which could cause it to fail after and upgrade for the sites using the old default behavior.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp741788_install_marc_stream_importer