3.13 previous templates cloned will lose column connections

[Blake GH]

After upgrading to 3.13, we found that all of our report templates that used any date field from any table no longer has the transform. Specifically the "Date" transform. It seems the other transforms (Month, Year+Month, etc) are working. Just the "Date" transform (which is the most popular).

A work around: clone the template and fix the transform for both Display and Filter when applicable.

[Andrea Neiman (aneiman)]

Blake, as a data point, is this happening regardless of the original template version or is it only happening to specific template version(s)?

[Blake GH (bmagic)]

After going through all of the templates, I found more things about v5->v6 templates that everyone might want to be aware of.

I found that the interface doesn't know that the displayed column is* the column choice. Now that we have the handy checkboxes as a visual cue, it makes it possible to get a glimpse under the hood.

Here is the relevant JSON snippets:

Result of cloning:
{""alias"":""Circ ID"",
""path"":""Circulation_id"",
""relation"":""fce458da5814089639960610c48d19d2"",
""column"":{""colname"":""id"",
""transform"":""count_distinct"",
""aggregate"":true}},

Result of adding the same column:
{""alias"":""Circ ID"",
""path"":""circ.id"",
""relation"":""fce458da5814089639960610c48d19d2"",
""column"":{""colname"":""id"",
""transform"":""count_distinct"",
""aggregate"":true}}],

It seems the key difference is:
Circulation_id
vs
circ.id

I found that either one works as far as the report functionality is concerned. It still produces the same result, but the interface doesn't "know" that Circulation_id needs to connect to the checkbox

See attached screenshot.

It's probably best to re-create, from scratch, all of your templates when migrating to the new reporter code. Because of the column checkbox connection to the displayed/filtered selections, it's best to do the following:

1. Upgrade to Evergreen 3.13
2. Clone a template that existed prior to upgrade.
3. While still in the clone editor, find and add each display column, position it, then delete the old column from the display.
4. Repeat for all Displayed columns
5. Repeat for all Filtered columns
6. Save template

[Galen Charlton (gmc)]

Blake, could you share the full JSON of the pre-clone template and the post-clone one?

[Galen Charlton (gmc)]

Also, in my opinion it is premature to make recommendations to recreate report templates during an upgrade to 3.13; one of the design points of the new interface is to _not_ have to do that. Consequently, any bugs in that area should get fixed, not worked around.

[Blake GH (bmagic)]

Attaching "Overdues - item due before specified date - 3.13.0.json"

[Blake GH (bmagic)]

Attaching "Overdues - item due before specified date - 3.11.1.json"

[Mike Rylander (mrylander)]

Blake, thanks for the data. It doesn't look like the the latest attachments (comments 5 and 6) are related to the the details listed in the early comment 2. Is that correct? If so, what is the focus you're concerned with on those attachments? Is it the initial date-transform concern from the initial report?

[Mike Rylander (mrylander)]

Regarding the "date" transform, the branch linked below normalizes the old and new spellings of that transform, as well as the "count" transform (now always spelled "count_distinct") and adds the "round" transform.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-2071372-new-reporter-transform-needs

Pullrequesting the branch, as it addresses the original report. I'll wait for more information regarding the followup comments -- not sure what the concern is there, yet.