Comment 1 for bug 2063849

Here is a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2063849-staff-catalog-hidden-ous / user/sandbergja/lp2063849-staff-catalog-hidden-ous
Here is a 3.12-compatible branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2063849-staff-catalog-hidden-ous-3-12 / user/sandbergja/lp2063849-staff-catalog-hidden-ous-3-12

Here are some testing notes:

1. Use the OU admin screen (Administration > Server Administration > Organizational Units) to set some systems, branches, bookmobiles, etc. to not be visible in the Staff Catalog. Include at least one case in which a branch is visible but its parent system is not. Note: if you are using the classic concerto data set, there is a new branch called BR5 that is not visible in the staff catalog.
2. Run autogen.sh as the opensrf user
3. Go to the staff catalog.
4. Open the staff catalog org unit selector. The expected behavior is that the org units that you hid in step 1 will no longer appear in the dropdown.
5. Do some searches for titles that can only be found at the org units that you hid in step 1. Expected behavior is that they will not appear in the search results.
6. Search for a title at the visible branch with an invisible system parent. Expected behavior is that the item counts on the search result screen will include counts for the consortium and the branch, but not the hidden system.

Note that this bug has some definite similarities to bug 1849497. The main difference is that this totally takes non-visible org units out of the library selector in the UI, and takes away the ability to search them. Josh's patch leaves the orgs in the library selector as an opt-in, so that it's still possible to do searches at those orgs if needed.

Not adding pullrequest yet, to give NOBLE a chance to test this.