Thanks, Michele. I've done some testing as well and here are my thoughts:
1) If there are no transactions selected, the idempotency key should incorporate the patron ID and the amount and the date. That way two users could pay the same amount on the same day with Pay All Charges, and one user could pay different amounts on the same day or the same amount on different days. I plan to do this.
2) There is still something fishy that causes "While you were trying to make payments, this account's transaction history changed. Please go back and try again.". I believe this was the scenario:
- pressed Pay Selected Charges
- in my debug logs I see "creating intent for xact=487,489 key=dacd248e707c09e30014e18a61df2da1"
- on the CC entry screen pressed back
- pressed Pay Selected Charges
- in my debug logs I see "creating intent for xact=487,489 key=dacd248e707c09e30014e18a61df2da1"
- entered the CC and submitted
- Stripe says the payment was successful
- EG says it wasn't: "While you were trying to make payments, this account's transaction history changed." (Interestingly that check was targeted at this same issue. See commit c5d36d2a99e45b9a02d00a1e795b66a38c271b43.)
Now if I retry the same payment, I get "A processing error occurred."
Thanks, Michele. I've done some testing as well and here are my thoughts:
1) If there are no transactions selected, the idempotency key should incorporate the patron ID and the amount and the date. That way two users could pay the same amount on the same day with Pay All Charges, and one user could pay different amounts on the same day or the same amount on different days. I plan to do this.
2) There is still something fishy that causes "While you were trying to make payments, this account's transaction history changed. Please go back and try again.". I believe this was the scenario: c09e30014e18a61 df2da1" c09e30014e18a61 df2da1" a02d00a1e795b66 a38c271b43. )
- pressed Pay Selected Charges
- in my debug logs I see "creating intent for xact=487,489 key=dacd248e707
- on the CC entry screen pressed back
- pressed Pay Selected Charges
- in my debug logs I see "creating intent for xact=487,489 key=dacd248e707
- entered the CC and submitted
- Stripe says the payment was successful
- EG says it wasn't: "While you were trying to make payments, this account's transaction history changed." (Interestingly that check was targeted at this same issue. See commit c5d36d2a99e45b9
Now if I retry the same payment, I get "A processing error occurred."