Confirmed that if I have changed the value of this setting, then try to run the 3.11.1-3.12 upgrade script, I get:
ERROR: insert or update on table "org_unit_setting_type_log" violates foreign key constraint "org_unit_setting_type_log_field_name_fkey"
DETAIL: Key (field_name)=(opac.did_you_mean.max_suggestions) is not present in table "org_unit_setting_type".
Confirmed that the problem goes away when using your version, Blake. Thanks for catching and fixing this!
Confirmed that if I have changed the value of this setting, then try to run the 3.11.1-3.12 upgrade script, I get:
ERROR: insert or update on table "org_unit_ setting_ type_log" violates foreign key constraint "org_unit_ setting_ type_log_ field_name_ fkey" name)=( opac.did_ you_mean. max_suggestions ) is not present in table "org_unit_ setting_ type".
DETAIL: Key (field_
Confirmed that the problem goes away when using your version, Blake. Thanks for catching and fixing this!
Signedoff and merged to rel_3_12 and main.