ADMIN_BIB_BUCKET and CREATE_BIB_BUCKET permissions are missing from seed files

[Llewellyn Marshall]

Evergreen 3.11

At NC Cardinal we were attempting to set up carousel access for branch admins but the page wouldn't load for them. After some digging, we found that this was because they were unable to access buckets that belonged to other users. In FM_IDL.xml, we found that bib buckets had two permissions that were not found anywhere else in the system. These permissions are:

+ADMIN_BIB_BUCKET
+CREATE_BIB_BUCKET

The carousel administration page functioned normally after ADMIN_BIB_BUCKET was created and assigned to the branch admin permission group.

We're going to create a small patch that will add these two permissions to the seed file.

related bugs:
https://bugs.launchpad.net/evergreen/+bug/1851879
https://bugs.launchpad.net/evergreen/+bug/1901888

[Llewellyn Marshall (lbmarshallv)]

patch to address this issue:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp2051140_missing_bucket_perms

[Galen Charlton (gmc)]

The update script will need to account for the possibility that the permissions in question were already manually added to the database, as is the case with at least three of Equinox's customer's databases.

Since the permission ID value doesn't matter, just the code, 1191.data.lp1842940_staff_edit_self_perm.sql gives an example of how to do it.

[Llewellyn Marshall (lbmarshallv)]

fixed up the update script to account for that.

[Jane Sandberg (sandbergja)]

Thanks for the branch, Llewellyn! Would it be okay to add the pullrequest tag to this bug?

[Llewellyn Marshall (lbmarshallv)]

You're welcome! I just added pullrequest to the tags

[Michele Morgan (mmorgan)]

Marking Confirmed. We are running into this as well.

[Jane Sandberg (sandbergja)]

Thanks, Llewellyn! We reviewed this in the collaborative code review meeting, and Blake pushed it to rel_3_12 and above.

[Jason Stephenson (jstephenson)]

Should this patch be back ported to rel_3_11? It was reported there.