I think this is quite close, but I have a question about commit 84fa09ce0c0. This isn't purely a whitespace-and-reformatting patch as described in the commit message, but also includes some substantive changes.
Some of them make sense: e.g., the patch series starts by setting vandelay.queued_bib_record.create_time as required, but 84fa09ce0c0 reverses that. By your criteria, it should _not_ be marked required, as create_time has a default value.
Others do not: 84fa09ce0c0 reverses the changes made by the first patch in the series and marks several fields in metabib.display_entry as not required. However, the first patch was correct - as non-NULL fields with no default value, they should have been marked required.
I think this is quite close, but I have a question about commit 84fa09ce0c0. This isn't purely a whitespace- and-reformattin g patch as described in the commit message, but also includes some substantive changes.
Some of them make sense: e.g., the patch series starts by setting vandelay. queued_ bib_record. create_ time as required, but 84fa09ce0c0 reverses that. By your criteria, it should _not_ be marked required, as create_time has a default value.
Others do not: 84fa09ce0c0 reverses the changes made by the first patch in the series and marks several fields in metabib. display_ entry as not required. However, the first patch was correct - as non-NULL fields with no default value, they should have been marked required.
What's going on with that commit?