Comment 19 for bug 2050227

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Galen,

I'll respond to your latest 3 comments in order:

Regarding the asset.call_number columns being required and that potentially causing issues, I'm OK with removing the required attribute from these fields as long as doing so solves a problem, i.e. data being saved or not. (Perhaps prefix and suffix should have default values of -1? That's a different bug if so.) If you want to leave this as is, I'm OK with that, too.

I didn't look specifically at asset call numbers with these changes. I was mainly focused on the settings editor and related interfaces. I can also go back and test the volume editor specifically if you want.

I'm OK with backporting to 3.12 and 3.11. I didn't initially target this bug at those releases because I was concerned about drift in the IDL between those branches and main. Presently, I don't think there is any drift between 3.12 and main, and I have not checked 3.11.

Yes, if you want to add the fix_idl_require.pl program to examples or some new delvelopment support scripts directory, that would be fine with me. Perhaps it could be expanded in the future to check more apsects of the IDL?