The first (call number labels) is taken care of via the holdings editor changes in bug 1821950.
The second and third (call number affixes) are a special case. The ID = -1 rows must have the empty string as their value, but I can't imagine at present needing rows where the empty string call number affix value must also exist at other owners in the OU hierarchy.
As a consequence of this patch, the -1 affixes can be opened in the Angular admin interfaces but not saved. However, since the only time you'd need to do this is manually correcting the default entries if the root node of your OU tree does not have ID 1, I think this is enough of an edge case to ignore for the purpose of this patch (though it should be written up as a new bug).
Signoff branch pushed to working/ user/gmcharlt/ lp2050227_ signoff.
There are at least three columns now marked required where the empty string can be valid value:
asset.call_ number. label number_ prefix. label number_ suffix. label
asset.call_
asset.call_
The first (call number labels) is taken care of via the holdings editor changes in bug 1821950.
The second and third (call number affixes) are a special case. The ID = -1 rows must have the empty string as their value, but I can't imagine at present needing rows where the empty string call number affix value must also exist at other owners in the OU hierarchy.
As a consequence of this patch, the -1 affixes can be opened in the Angular admin interfaces but not saved. However, since the only time you'd need to do this is manually correcting the default entries if the root node of your OU tree does not have ID 1, I think this is enough of an edge case to ignore for the purpose of this patch (though it should be written up as a new bug).