Comment 16 for bug 2050227

Revision history for this message
Galen Charlton (gmc) wrote :

Signoff branch pushed to working/user/gmcharlt/lp2050227_signoff.

There are at least three columns now marked required where the empty string can be valid value:

asset.call_number.label
asset.call_number_prefix.label
asset.call_number_suffix.label

The first (call number labels) is taken care of via the holdings editor changes in bug 1821950.

The second and third (call number affixes) are a special case. The ID = -1 rows must have the empty string as their value, but I can't imagine at present needing rows where the empty string call number affix value must also exist at other owners in the OU hierarchy.

As a consequence of this patch, the -1 affixes can be opened in the Angular admin interfaces but not saved. However, since the only time you'd need to do this is manually correcting the default entries if the root node of your OU tree does not have ID 1, I think this is enough of an edge case to ignore for the purpose of this patch (though it should be written up as a new bug).