Add Public Copy Notes to MARC export when items requested

Bug #2045440 reported by Jason Stephenson
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
New
Wishlist
Unassigned

Bug Description

We've had a request to add public copy notes to the 852 subfield z when items are exported via MARC export.

We'll also probably want to add these to the marcxml-full SuperCat and UnAPI exports as well.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have pushed a branch to the working repository for this feature: user/dyrcona/lp2045440-marc-export-public-copy-notes (https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp2045440-marc-export-public-copy-notes).

If we decide to add this to SuperCat/UnAPI, then that should be done under the Aegis of another bug. That's my opinion as of today and is subject to change depending on community feedback.

tags: removed: supercat
Changed in evergreen:
milestone: none → 3.next
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I am removing the pullrequest tag for now. I want to also add public copy tags to the code. I'll do so in an additional commit.

tags: removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

The branch now has two commits and was rebased on main.

The first commit adds public copy notes to the marc_export program as described above.

The second commit adds public copy tags. The copy tags are distinguishable from copy notes, because the copy tags have the tag type label prepended to them in the 852 subfield z.

There are release notes and tips on testing this new feature in the commit messages.

tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I am taking this one back. I've been asked to add the note titles to 852$z as well as the note values.

This came up after our first time using it in production.

Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
status: New → In Progress
tags: removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

The code has been modified to add the asset.copy_note titles to the public note entries in subfield z. If the title is not empty it gets added in the same way as the copy tag type, i.e. prepended to the value with a colon and a space, ": ".

The branch was also rebased on the latest master and force pushed to the working repository.

Changed in evergreen:
status: In Progress → New
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I'm taking this one back to investigate a potential bug with pulling out the notes that have empty titles. They don't seem to be showing up.

I'll double check the extraction of copy tags as well because they use similar logic.

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote (last edit ):

We have determined that the issue reported in comment #6 has nothing to do with empty titles. marc_export grabs those just fine with this branch applied.

It turns out that the issue has to do with our procedures for updating changed records with the discovery layer. We send a file every 10 minutes of updated bib ids, i.e. those that have been edited, had circulations, etc. The discovery then uses SuperCat to retrieve the updated record with item information. SuperCat does not match marc_export when export items in the 852. Several fields are missing.

I plan to add copy tags and copy notes to SuperCat item export as a part of this bug's branch.

I will open another bug for other "missing" 852 fields.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Well, I discovered that Evergeen does send copy notes in the SuperCat feed when items are requested. It looks like the discovery layer needs to be modified to read them. (I also erroneously thought that SuperCat sends the information in a 852 tag, but it adds its own XML to the end of the MARC. I guess I had forgotten about the different format.)

SuperCat does not send copy tags, and if we decide that is important, I'll open a new bug for that.

It also looks like some of the other "missing" information isn't missing, either. The discovery layer just needs code to be able to read it and put it in its own copy of the MARC 852.

I am satisfied that the code for this feature is working as intended. I'll remove the assignment and add the pullrequest tag.

Sorry for the noise/confusion. I'll blame it on the impending holidays and seasonal colds. :)

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have taken this bug back and removed the pullrequest tag for now. We're having internal discussions about changing the order that notes and tags are exported and adding the copy tag url field to the 852$u.

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

The sum of the feature consists of the top 3 commits in user/dyrcona/lp2045440-marc-export-public-copy-notes working branch (https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp2045440-marc-export-public-copy-notes). The branch has been rebased on main as of the time of this comment.

CW MARS has been using this in production for a couple or weeks now with no ill effects.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullr
tags: added: pullrequest
removed: pullr
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.