Comment 1 for bug 2044051

Revision history for this message
Dan Briem (dbriem) wrote :

I thought I'd also mention, VolCopyModule is tricky to import into other modules. Its VolCopyRoutingModule has very liberal route parameters that could unexpectedly hijack router outlets with VolCopyComponent. Also, CopyAlertsDialogComponent is declared and exported in HoldingsModule, which is imported in even more modules, so we may end up with more injection errors down the road.

Maybe we could provide VolCopyService and the dependent HoldingsService in root instead of providing them in their corresponding modules. They cache/memoize, but at first glance they don't appear to have mutable local state, with the possible exception of the current VolCopyContext on VolCopyService.

Or, I guess we could drop the dependence on VolCopyService in CopyAlertsDialogComponent and perform the ServerStoreService lookup for the item alert type when the dialog opens.