Problems deleting objects managed by AdminPageComponent

Bug #2043508 reported by Jason Boyer
32
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.11
Fix Released
High
Unassigned

Bug Description

3.11+

While working on the patch for bug 2039612 I found that it and several other admin pages are unable to delete things in Evergreen 3.11. I think it's related to the AdminPageComponent and the confirmation dialog that's supposed to open on delete, but I haven't gotten into it enough to track down a fix.

Affected local admin interfaces
Carousels
Search Filters
Distribution Formulas (acq)
Staff Portal
And possibly others, but that's enough to show something's up.

Jason Boyer (jboyer)
Changed in evergreen:
importance: Undecided → High
tags: added: admin-pages
tags: added: angular
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Weston (jweston) wrote :

Confirming I am unable to delete an entry for the Staff Portal Page on 3.11. It silently fails.
As a control, I tested the same action on 3.10 and it worked fine.

Revision history for this message
Forrest Tate (fotate) wrote :

Confirming unable to delete entry for Staff Portal Page on 3.11. I do get the popup to confirm or cancel the action, "Delete staff portal page entry or entries?" But it silently fails.

Revision history for this message
Llewellyn Marshall (lbmarshallv) wrote :

it looks like several of the delete dialogs were missing or misnamed.

I have a patch for this issue:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp2043508_admin_delete_dialog

Revision history for this message
Terran McCanna (tmccanna) wrote :

Susan, Tiffany, and I tested all of the various changed components and delete is working - woo hoo!

Sign-off branch is at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=summary

Changed in evergreen:
milestone: none → 3.12.2
tags: added: pullrequest signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Branch is user/mccanna/lp2043508_admin_delete_dialog_signoff, I assume?

Revision history for this message
Terran McCanna (tmccanna) wrote :

Yes, sorry!

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbergja)
Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
status: Confirmed → Fix Committed
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Jason, Llewellyn, Terran, Susan, Tiffany, and all others who helped to squash this bug! Pushed to rel_3_11 and above.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.