Carousels - Carousels Can't be Created or Edited

[Jennifer Pringle]

Evergreen 3.11

Carousels (from Administration -> Local Administration -> Carousels) can't be created or edited in 3.11. We can currently create and edit carousels without issue in 3.9.

You can fill in all the information on the New Carousel pop up but when you save nothing happens and you get the following console error.

main.f94026d6a1e1af6d.js:3 ERROR TypeError: Cannot read properties of undefined (reading 'user')
    at o.mungeCarousel [as preSave] (171.4a7dfbbc87321a2d.js:1:10781)
    at o.save (3373.fa2d2eb146a57188.js:1:18392)
    at 3373.fa2d2eb146a57188.js:1:11847
    at yg (main.f94026d6a1e1af6d.js:3:167066)
    at c (main.f94026d6a1e1af6d.js:3:167233)
    at HTMLButtonElement.<anonymous> (main.f94026d6a1e1af6d.js:3:284424)
    at v.invokeTask (polyfills.639b7e14253a83b2.js:1:7210)
    at Object.onInvokeTask (main.f94026d6a1e1af6d.js:3:207079)
    at v.invokeTask (polyfills.639b7e14253a83b2.js:1:7131)
    at M.runTask (polyfills.639b7e14253a83b2.js:1:2575)
handleError @ main.f94026d6a1e1af6d.js:3
Jp @ main.f94026d6a1e1af6d.js:3
yg @ main.f94026d6a1e1af6d.js:3
c @ main.f94026d6a1e1af6d.js:3
(anonymous) @ main.f94026d6a1e1af6d.js:3
invokeTask @ polyfills.639b7e14253a83b2.js:1
onInvokeTask @ main.f94026d6a1e1af6d.js:3
invokeTask @ polyfills.639b7e14253a83b2.js:1
runTask @ polyfills.639b7e14253a83b2.js:1
invokeTask @ polyfills.639b7e14253a83b2.js:1
Z @ polyfills.639b7e14253a83b2.js:1
N @ polyfills.639b7e14253a83b2.js:1
F @ polyfills.639b7e14253a83b2.js:1

I've tried on our test servers and EOLI's 3.11 community server both as a global admin and as a local system administrator with the permissions ADMIN_CAROUSEL and REFRESH_CAROUSEL applied and I can't get a carousel to save.

[Jason Boyer (jboyer)]

It would seem that things were a little looser in previous versions of Angular (or TypeScript), so now if you want to use this.thing your function had better also be a this.that.

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2039612_oop_fun / working/user/jboyer/lp2039612_oop_fun

[Jane Sandberg (sandbergja)]

Wow, good catch! Thanks, Jason! That indeed fixes the issue, so I pushed my signoff to user/sandbergja/lp2039612_oop_fun.

I'd gotten as far as writing a little nightwatch test that failed for the right reason. With your patch, it now passes for the right reason, so I pushed the test to that branch as well as a separate commit.

[Andrea Neiman (aneiman)]

Adding targets for main & 3.11 - I have not looked at this on 3.10

[Michele Morgan (mmorgan)]

This issue is also present in 3.10. Pushed to main, rel_3_11 and rel_3_10.

Thanks Jason and Jane!

I've adjusted the targets as this is a bugfix.

[Jason Boyer (jboyer)]

FYI, this fix is apparently only 1/2 complete. Now you can add new carousels but deleting them fails with an error trying to display the confirmation dialog. This problem effects multiple Local Admin pages on 3.11 (with or without this patch present) so I'll open a new bug to address it.