Shelving Location Groups admin screen accessibility

[Stephanie Leary]

In Administration > Local Administration > Shelving Location Groups (/eg2/en-US/staff/admin/local/asset/shelving_location_groups), the entire screen is inaccessible to keyboard / screen reader users.

There are several issues here:

* Almost all the actions on this page are (click) handlers on <div> tags that should be <button> instead (see https://wiki.evergreen-ils.org/doku.php?id=accessibility:links).
* There are separate <eg-staff-banner> tags for each column, when there should be one at the top of the page that also includes the tab title (see bug 1994711). The rest should be <h2> tags.
* The list of shelving location groups in the left column should be a table instead of using Bootstrap grid classes.
* The drag and drop icon should be a <button> tag with a keyboard handler so the rows can be moved up or down one at a time using the arrow keys.
* In the checkbox lists under Group Entries and Shelving Locations, there are duplicate entries in the list. Because the duplicates share IDs, the labels are not correctly associated with the inputs.

[Beth Willis (willis-a)]

3.11.1

The entries in the Shelving locations column sort alphabetically by System and then again by Branch.

The Group Entries column is not sorted alphabetically. This makes it difficult to identify which shelving locations from each System and Branch are included in the group, especially when displaying data at the Consortium level. I think the Group Entries column should sort alphabetically by default. I think it would also be preferable if both the Group Entries and Shelving Locations columns displayed locations owned by branches under the locations owned by their respective Systems.

Please see attached screenshot.

[Stephanie Leary (stephanieleary)]

Beth, did you mean to file a new bug?

[Beth Willis (willis-a)]

At Stefanie's suggestion, I have opened a separate bug related to my comment: https://bugs.launchpad.net/evergreen/+bug/2045924

Thank you, Stefanie.

[Jane Sandberg (sandbergja)]

Confirmed. Also, the org unit selector is not associated without its label. The eg-org-select id="context-ou" attribute should be domId="context-ou"

[Stephanie Leary (stephanieleary)]

Here's a branch with the revamped Shelving Location Groups admin screen:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2042879-shelving-location-groups-admin-accessibility

This doesn't address the sorting issue Beth mentioned. Thank you for filing that separately, Beth!

It does fix the duplicate shelving locations in the two lists on the right (thanks to Mike!), as well as all the keyboard navigation issues noted in the bug description.

It also changes the way positions are updated to prevent the position numbers from ballooning as you rearrange the groups. It now updates only the positions between the first and last group affected by the drag and drop, rather than everything from the first group onward. This should be much more efficient when there are a lot of groups.

[Jane Sandberg (sandbergja)]

We reviewed this today in the collaborative code review, and it makes great improvements! Thanks, Stephanie! Pushed to rel_3_12 and above with signoffs from Terran, blake, Steven, Shula, and myself.