Staff pages lack H1 headings

[Stephanie Leary]

Other than the login page, all the pages in the staff view lack H1 headings. This is required as part of WCAG 1.3.1; see https://www.w3.org/WAI/WCAG21/Techniques/html/H42 for details.

Patch forthcoming.

[Stephanie Leary (stephanieleary)]

Branch fixing the issue: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1994711-semantic-h1-titles

I would appreciate feedback on the visual changes here; I can adjust the CSS to keep the blue, centered titles if people feel strongly about it.

[Galen Charlton (gmc)]

I vote for keeping the blue, centered page titles. Not out of any particular attachment to the previous styling, but for consistency with some of the AngularJS interfaces as well as reducing the need to regenerate screenshots for the documentation.

[Stephanie Leary (stephanieleary)]

Shelving my desire to redesign all the admin screens immediately... I've updated the branch to make the new H1s match existing page titles.

[Terran McCanna (tmccanna)]

Just to clarify, this only changes the Angular pages, correct?

I have not checked every Angular page, but I do see the new H1 on all that I have checked.

Although I appreciate having the titles there, they look very squished together with the action buttons on many of the interfaces (see attached screenshot). Whether or not we stick with the blue, centered titles that we have in some of the AngularJS pages or not, I do think they could use a little more visual separation.

It would also be nice to have the same changes made to the AngularJS pages, as many of those are missing H1s as well.

[Stephanie Leary (stephanieleary)]

My apologies, Terran, I left out a commit. I've just rebased this to restore the surrounding div with the blue styling.

[Jason Boyer (jboyer)]

Hi Stephanie, it looks like there's an issue in the Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts change where a bare '-' snuck into a div tag and breaks the client.

[Stephanie Leary (stephanieleary)]

Thanks, all! I've updated this branch.

[Jane Sandberg (sandbergja)]

Thanks, Stephanie! It's looking good to me. Just one question: your patch removes <eg-staff-banner>'s functionality to set the page's <title> via <eg-title>. Many screens have a redundant <eg-title>, so this patch doesn't affect them. However, there are a few that don't have this, like:

* Hamburger menu > About
* Admin > Server Admin > MARC Coded Value Maps

I could see two approaches to make sure that these screens don't lose their <title>s:
* In this branch, also add <eg-title> to any screens that don't already have one, or
* keep the <eg-title> piece in the <eg-staff-banner>

[Stephanie Leary (stephanieleary)]

Thanks, Jane. I am puzzled by the inconsistent methods of setting <title> and I think we should revisit it at some point, but for now I've added <eg-title> back to the banner, this time outside the markup to make it clearer that it is not part of the visible text.

[Jane Sandberg (sandbergja)]

Thanks, Stephanie! Signoff here: user/sandbergja/lp1994711-semantic-h1-titles-signoff

[Galen Charlton (gmc)]

Tested and pushed down to rel_3_10. Thanks, Stephanie and Jane!