Acq: Multi-Branch Libraries Can't See All Their Branch Funds

[Jennifer Pringle]

Evergreen 3.11.1

Unfortunately the fix for https://bugs.launchpad.net/evergreen/+bug/1999544 does breaks acquisition for multi-branch libraries who do centralized ordering using branch level funds.

Library staff can only see the funds for the branch they are logged in at and the ancestors.

There are a few bugs around this issue with possible solutions:

https://bugs.launchpad.net/evergreen/+bug/2007322
https://bugs.launchpad.net/evergreen/+bug/1994985

We'd like to suggest another possible solution. For selection lists and purchase orders, have Evergreen decide what funds to display in the drop down for the batch item updater and the Items page based on what the user picks for Item Owning Library. Once you enter a value for Item Owning Library you would then be given a list of funds belonging to that library/branch and its ancestors. (This should also apply when setting up distribution formula.)

We couldn't think of a case where you'd want to pay for an item for one branch with funds for another. (If you overspend in one fund and under spend in another other you should transfer money from one fund to the other.)

I think this bug is a blocker for future releases (we've had to revert the fix so our multi-branch libraries can use acquisitions).

[Tiffany Little (tslittle)]

I have a pullrequest here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP2040637_Viewbranchfunds

The fix for bug 1999544 relied on the ancestors of the workstation where the user was logged in as. Dojo relied on the permissions of the user and their available depth. Specifically, the fund selector for line items checked MANAGE FUND, CREATE_PURCHASE_ORDER, and CREATE_PICKLIST. The fund selector for PO direct charges checked MANAGE_FUND and CREATE_PURCHASE_ORDER.

This new branch now should behave the same way as Dojo, where it's checking the perms available to the user and where they can use them.

[Ruth Frasur Davis (redavis)]

We were able to test this fix on our local production test server and verify that it works.

I consent to signing off on it with my name, rfrasur/redavis, and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed to main, rel_3_12, and rel_3_11. Thanks, Tiffany and Ruth!