Angular funds dropdown not populating

[Tiffany Little]

Testing on a copy of our production data with 3.10.

In the fund dropdowns in the new PO/LI interface, funds that I knew were there were not populating. For one library system, there was nothing when I clicked the fund dropdown. For others, if I started typing the fund it would populate the list. Subsequently clicking in the dropdown while in the same modal would show those funds now in the dropdown list. However, once you leave the modal and then click the dropdown again, they're gone and you're left with only those initial options (if there were any).

I think there's two things going on here. In PINES, we have 624 active funds at the moment. There's a limit of 100 retrieved on comboboxes.

In /acq/lineitem/copy-attrs.component.html, the combobox for fund is only filtering on that the fund is active. Then it's sorting first by year, then by code. So I queried our DB and set it up the same way and limited to the first 100 entries, and sure enough that matched up with what I saw in the UI.

So the first thing is that this combobox needs another limiter. I have a potential patch that I'm testing that adds a limit of owning org, but I can only test it with our production data since there's not 600+ funds on Concerto.

Opening a subsequent bug around the options vanishing once you leave the modal.

[Tiffany Little (tslittle)]

Bug about fetchFunds here: bug 1999547

[Jennifer Pringle (jpringle-u)]

Possibly related to the similar sounding issue with the shelving location drop down menu??

https://bugs.launchpad.net/evergreen/+bug/1995418

[Tiffany Little (tslittle)]

Tested this on our production data and it fixes the issue. There's still the limit of 100 funds appearing in the dropdown, but for any org with less than that all funds should now display.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1999544_funddropdown

[Tiffany Little (tslittle)]

I just realized that the fund dropdown in PO direct charges suffers from the same affliction, so I added another commit to the same branch to address those.

[John Amundson (jamundson)]

This works well in my testing, both for line items and PO direct charges. Adding my sign-off. Thanks, Tiffany!

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

[Jason Stephenson (jstephenson)]

Signoff branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/LP1999544_funddropdown-signoff

[Jason Stephenson (jstephenson)]

I pushed this to master and rel_3_10 this morning. Thanks, Tiffany, Jennifer, and John!

[Galen Charlton (gmc)]

I've reservations about this: specifically, I think it risks disrupting workflows that do centralized ordering using decentralized funds. However, I don't think it necessarily warrants a revert.

I've written up more as well as a possible solution on bug 2007322.