Hah I just saw Terran's comment! Related, there are several commits which have no sign offs.
Other testing notes:
* I could not get Brief Record templates to do anything (local test VM and butternut). Maybe I'm expecting the wrong thing.
* Applying a brief record template as a default saves the value, but does not load the applied template on page reload.
* Invoice comboboxes show repeated options (e.g. "Paper" shows twice for if it's set on page load).
* Needs "ng lint --fix"
* For consistency, for blanket charges, the Billed and Paid amounts should be empty when creating a new invoice.
* Minor console error fix:
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/brief-record.component.html @@ -36,7 +36,7 @@ <div class="flex-1"> <button class="btn btn-secondary" - [disabled]="selectedMARCTemplate.id == '__blank__'" + [disabled]="selectedMARCTemplate && selectedMARCTemplate.id == '__blank__'" (click)="setWSDefaultTemplate()" i18n>Set Default</button> </div> </div>
Hah I just saw Terran's comment! Related, there are several commits which have no sign offs.
Other testing notes:
* I could not get Brief Record templates to do anything (local test VM and butternut). Maybe I'm expecting the wrong thing.
* Applying a brief record template as a default saves the value, but does not load the applied template on page reload.
* Invoice comboboxes show repeated options (e.g. "Paper" shows twice for if it's set on page load).
* Needs "ng lint --fix"
* For consistency, for blanket charges, the Billed and Paid amounts should be empty when creating a new invoice.
* Minor console error fix:
+++ b/Open- ILS/src/ eg2/src/ app/staff/ acq/lineitem/ brief-record. component. html ="selectedMARCT emplate. id == '__blank__'" ="selectedMARCT emplate && selectedMARCTem plate.id == '__blank__'"
(click) ="setWSDefaultT emplate( )" i18n>Set Default</button>
@@ -36,7 +36,7 @@
<div class="flex-1">
<button
class="btn btn-secondary"
- [disabled]
+ [disabled]
</div>
</div>