Comment 3 for bug 2037674

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I stepped through the code again in developer tools... and I think that the sort can just be removed.
The ngForOf that populates the combobox entries seem to be running before the sort happens, or at the same time.

Looking now I can see that the sort actually does start to change the last 20 or so entries in my test bib by the time the combobox entries are created.

I'm testing with a magazine bib that is loading 288 parts to give it a good workout.

So the .subscribe in fetchBibParts executes the first function to push the parts into bibParts, after that completes, it seems like the ngFor starts populating the combobox, and then the .subscribe 3rd function gets called and starts the sort....

I removed the pullrequest until I have a chance to update the branch.
Josh