Unable to see or edit some item alerts, notes, and tags

Bug #2020589 reported by Jason Boyer
54
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Undecided
Unassigned

Bug Description

Evergreen 3.10+

The Angular item editor has dialogs for managing the alerts, notes, and tags assigned to copies. In bug 1983628 support for editing notes was added, but there are additional similar issues that need to be resolved.

For all 3 types of information you cannot see what new things are created in the current editing session (i.e. what will be created when saving), only those things that already existed in the database when the item was loaded. An effort was clearly made to display new notes in the previously referenced bug but something still isn't working there.

Tags cannot currently be edited, only removed and re-created.

Additionally, Alerts display in a manner that enables editing at any time, while notes requires clicking an Edit button. Should one style or the other be picked and the other two brought in line, or is there a reason to have these two different editing methods?

tags: added: cat-itemalerts cat-itemnotes cat-itemtags
Revision history for this message
Elaine Hardy (ehardy) wrote :

I think having the same style for editing is best. I slightly prefer not having an additional click on an edit button but am fine with the button.

Revision history for this message
Elaine Hardy (ehardy) wrote (last edit ):

In 3.10...... In the holdings view, I do see existing and new notes and alerts added, both in add/manage options from the action menu and the holdings editor. (see attached)

In item status, I don't see the existing alerts in add alerts and only see the existing in manage alerts.

Revision history for this message
Elaine Hardy (ehardy) wrote :
Revision history for this message
Jason Boyer (jboyer) wrote :

Thanks for pointing that out Elaine. I tested a couple versions of Eg and it looks like at some point between 3.10.0 and master the pending new items display got broken. :-(

Or at least this workflow is broken:
Open item editor
Click Item Alerts (or tags or notes)
Add at least one new alert in the dialog that pops up
Click Apply Changes to close the dialog
Click the Item Alerts button again - no new alerts are displayed
New alerts are not displayed until the item is saved.

Revision history for this message
Elaine Hardy (ehardy) wrote :

Very good catch! I was not applying changes and then reopening the dialog box. As you note, clicking on apply changes closes the dialog box and the note/alert is invisible if you reopen the note/alert editor before you save the item(s) (we haven't implemented tags, so I can't test that).

It would be extremely helpful if they displayed, perhaps with a pending or new label similar to the "Existing Notes" label. And with a remove button and capability to edit .

Revision history for this message
John Amundson (jamundson) wrote (last edit ):

Related bugs explicitly calling out...
Item Notes: Bug 2044026
Item Alerts: Bug 2044028

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Andrea Neiman (aneiman) wrote :

This will be addressed as part of bug 2074112.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.