Keyboard support for links in PO line item list

Bug #2019032 reported by Stephanie Leary
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

While fixing bug 2009092, I found that the single PO view has numerous keyboard navigation issues related to missing form labels and links used in place of buttons.

Branch coming up.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch with numerous fixes:;a=shortlog;h=refs/heads/user/sleary/lp2019032-lineitem-list-keyboard-support

* <a click()> is now <button type="button">
* All <button>s have a type, to avoid accidentally submitting forms using Spacebar/Enter
* Items in dropdown lists have ngbDropdownItem directive for
keyboard up/down arrow support
* Icons are now aria-hidden (except "close," which is fine as-is)
and their parent elements have ARIA labels where necessary
* Text inputs have labels instead of placeholders

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off. Signoff branch is user/gmcharlt/lp2019032_signoff.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
tags: added: signedoff
Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

I've rebased my signoff branch in light of the patch for bug 2019117 getting merged.

Revision history for this message
Galen Charlton (gmc) wrote :

Given the time that has passed (and my need to push something to trigger the GitHub ng lint action), I've pushed this down to rel_3_11 on the strength of my signoff. Thanks, Stephanie!

Changed in evergreen:
milestone: none → 3.11.1
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.