two line item actions broken after upgrade to Angular 15

Bug #2019117 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

The "Add Brief Record" and "Load Bibs and Items" actions from the line item list in the Angular acquisitions interfaces fail after the upgrade of the Angular staff client to Angular 15.

It turns out that the routerLink values associated with the menu items were always wrong, but for some reason Angular 12's router worked around the error.

Evergreen 3.11

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → High
tags: added: acq-lineitem angular regression
Changed in evergreen:
milestone: none → 3.11-beta
Revision history for this message
Galen Charlton (gmc) wrote :

Patch available in user/gmcharlt/lp2019117-fix-two-li-actions / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2019117-fix-two-li-actions

As a note to committers, this patch very likely would have a merge conflict with bug 2019032 if that one goes in first (or vice versa). Either way, the intent of this patch is simply to remove one of the dots from two routerLink values.

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Also noting that the patch removes the only two occurrences of 'routerLink="../', so whatever is going on, the line item manager is hopefully the only interface that ran into this particular issue.

Revision history for this message
Jason Boyer (jboyer) wrote :

Works for me, signoff is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2019117-signoff / working/user/jboyer/lp2019117-signoff

Both actions were broken before patching, and work after.

Galen Charlton (gmc)
tags: added: signedoff
Jeff Godin (jgodin)
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
Revision history for this message
Jeff Godin (jgodin) wrote :

Pushed to master and rel_3_11. Thanks, Galen, Jason!

Changed in evergreen:
status: New → Fix Committed
assignee: Jeff Godin (jgodin) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.