Evergreen

  1. Bug #2017034
  2. Comment #6

Comment 6 for bug 2017034

Revision history for this message
Galen Charlton (gmc) wrote :

Some feedback:

- (minor) Branch has merge conflicts again, albeit trivial ones
- (minor) The i18n attribute isn't needed AngularJS side
- For the AngularJS side, I think the additional CSS needs to be in style.css.tt2, not admin.css.tt2 (otherwise, the skip nav will work only in AngularJS admin interfaces)
- In both Chrome and Firefox on Win11, tabbing to the skip link on an Angular page, then hitting enter navigates to the splash page, not to the staff-banner fragment.