Staff catalog search results should include heading tags

[Stephanie Leary]

Adding heading tags to the title and author in the search results list would make it much easier for screen reader users to skim the list using their software's outline tools (which we can emulate using a browser extension that lists landmarks and headings).

Branch forthcoming.

Related: Bug #1615707, Bug #1994711

[Stephanie Leary (stephanieleary)]

Branch here:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2009865-catalog-search-result-headings

In conjunction with the fix for Bug #1994711, the resulting page outline is:

h1. Staff Catalog
h2. Search Results (N)
(repeat for each result:)
h3. [Title]
h4. [Author]
(repeat for each facet box:)
h4. [Facet title]

We might want to give the facet sidebar a screenreader-only subheading and adjust the heading levels of the facet titles, but that can be addressed separately.

[Benjamin Kalish (bkalish)]

Why would the title and author get separate heading at different levels? I'd also think it would be better if the facet box headings were not simply mixed with the search results–the idea of a screenreader-only subheading for the sidebar makes sense. Perhaps:

h1. Staff Catalog
h2. Search Results (N)
(repeat for each result:)
h3. [Title] [Author]
h2. Facets
(repeat for each facet box:)
h3. [Facet title]

[Stephanie Leary (stephanieleary)]

I agree that having the title and author in the same heading would be ideal, but it's not feasible with the current markup without redesigning the layout of the result--which I intend to do at some future date! At the moment, they're in separate Bootstrap layout rows, and there's no good way to smush them together.

[Jane Sandberg (sandbergja)]

I am +1 to using the titles in the search results as headings. In my opinion, the title functions as a heading by describing the content below it (i.e. the description of the work in the search results).

I am -1 to using the authors in the search results as headings, since they don't describe the content underneath them.

Also, with this patch, if a result does not have an author, a heading is still created, which is confusing. When I searched for "clarinet" in the concerto data set and opened the list of headings in the VoiceOver rotor, there were two headings that were just called "link".

[Stephanie Leary (stephanieleary)]

I went to update this branch and realized that there really wasn't anything preventing us from squashing the title and author into one heading. The order now matches Benjamin's suggested outline, with the hidden "Facets" heading inserted above the sidebar. Much better!

Since I was messing with the sidebar markup, I took the extra step of moving it after the results list in the source order. I've adjusted the CSS to preserve the left-right arrangement visually. I could open a separate ticket for that, but it felt like overkill.

The branch has been updated and rebased.

[Jane Sandberg (sandbergja)]

Thanks, Stephanie! I tested this with the Voiceover rotor; it provides a much better experience. I squashed your two commits and added my signoff at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2009865-signoff

[Galen Charlton (gmc)]

Tested and pushed down to rel_3_10. Thanks, Stephanie and Jane!