Thanks for this patch, Scott! It's 99% there! There were just 3 things I noticed:
* Your upgrade script adds a setting called "circ.hide_patron_strict_barcode", but the Angular and AngularJS parts consult a setting called "ui.circ.hide_patron_strict_barcode" (with ui at the start). These should match, or else the feature doesn't work.
* The new setting should also be included in the 950.data.seed-values.sql file, so that new installations also get this setting.
* For the angular parts, you will want `this.org.settings('ui.circ.hide_patron_strict_barcode')`, rather than `this.store.getItem` or `this.serverStore.getItem`
Thanks for this patch, Scott! It's 99% there! There were just 3 things I noticed:
* Your upgrade script adds a setting called "circ.hide_ patron_ strict_ barcode" , but the Angular and AngularJS parts consult a setting called "ui.circ. hide_patron_ strict_ barcode" (with ui at the start). These should match, or else the feature doesn't work. seed-values. sql file, so that new installations also get this setting. settings( 'ui.circ. hide_patron_ strict_ barcode' )`, rather than `this.store. getItem` or `this.serverSto re.getItem`
* The new setting should also be included in the 950.data.
* For the angular parts, you will want `this.org.