I went through this code again. It merges clean on main. The interface looks great! I've played around with the various features: moving fields with drag/drop, undo button, flat text and back, suggestion combobox for various subfields. It's all beautiful and much improved.
The database updates were the portion of concern for me. The upgrade script works. A fresh concerto database from seed works. I tested a pingest of the database, also works. The icons for the bibs remained after pingest.
A couple of small bugs I found:
1. The undo button doesn't do anything if the last thing that you did was to alter one of the major header pieces of the marc such as "type".
2. If you make a few edits in the enhanced editor, and switch to the flat text editor, and back again to the enhanced editor, the undo history goes away, but will return after making a new change (sometimes).
3. Dragging and dropping the fields in an upward direction will land the field in the visually previewed place. But dragging the field in a downward direction will land the field off-by-one from the bolded horizontal rule indicated.
I've added Jennifer's sign-off along with mine for the four-commits on this branch. And merged onto main! Stephanie: I think the drag-drop issue is worth opening a new bug report.
All,
I went through this code again. It merges clean on main. The interface looks great! I've played around with the various features: moving fields with drag/drop, undo button, flat text and back, suggestion combobox for various subfields. It's all beautiful and much improved.
The database updates were the portion of concern for me. The upgrade script works. A fresh concerto database from seed works. I tested a pingest of the database, also works. The icons for the bibs remained after pingest.
A couple of small bugs I found:
1. The undo button doesn't do anything if the last thing that you did was to alter one of the major header pieces of the marc such as "type".
2. If you make a few edits in the enhanced editor, and switch to the flat text editor, and back again to the enhanced editor, the undo history goes away, but will return after making a new change (sometimes).
3. Dragging and dropping the fields in an upward direction will land the field in the visually previewed place. But dragging the field in a downward direction will land the field off-by-one from the bolded horizontal rule indicated.
I've added Jennifer's sign-off along with mine for the four-commits on this branch. And merged onto main! Stephanie: I think the drag-drop issue is worth opening a new bug report.
Thanks everyone!