idlQuery for acq providers needs to be more strict

[Tiffany Little]

3.10.

There are three places where there's an idlQueryAnd for a combobox to pull up acq providers in 3.10. In all three places, the only criteria is just that the provider is active.

This leads to a situation similar to bug 1999544 where it's not initially limiting on org so it's bringing back too many results. We currently have 419 active providers in PINES. Although users aren't seeing results they shouldn't, their list is being unnecessarily truncated. It also takes a long time for the dropdown to pop at all--at least a five full seconds once you click it, which makes the user think that nothing's happening at all.

These three places should include an initial org limitation from the outset to limit the results returned. Working on a patch for this now.

[Tiffany Little (tslittle)]

Patch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=a2c4032366ab9ff0c1b8fbfe46f34fb0ec331e47

This is working seemingly as intended on a copy of our production data.

[Christine Morgan (cmorgan-z)]

Tested on https://tiffany-master.gapines.org, logged in as admin with a workstation location of BR1.

I tested this in Create Purchase Order and in Load MARC Order Records interfaces.

Clicking in the Provider field in the Load MARC Order Records form initially shows providers ACORN (SYS1) through Midwest (BR1). So that is the first 100 or so providers, listed alphabetically. To see providers beyond Midwest, I typed the letter "s" which retrieved any provider with a "s" in the name or org unit. In other words typing "s" will include ALA (SYS1) in the list. Over 100 providers displayed in the drop down with the "s" search.

Entering "x" in the provider field retrieved six providers including WT Cox (SYS1), WT.Cox (BR1), and WTCOX (SYS1). Blanking the Provider field and clicking on the double arrows I see the first 100 providers again [ACORN (SYS1) through Midwest (BR1)] plus WT Cox (SYS1), WT.Cox (BR1), and WTCOX (SYS1), which seems a bit odd but probably not a real issue.

I found the drop down a bit confusing until I figured out what it was doing. The filtered drop down updated immediately and it did not appear that any providers were missing in the filtered list.

I'm willing to sign off on this if other find the behavior acceptable.

[Terran McCanna (tmccanna)]

Removing pullrequest until comment #2 is resolved or accepted one way or another