Comment 2 for bug 2001728

Good catch, John.

I think in the long run one part of the answer will be modifying action.aged_circulation to permit circ_staff to be nullable and having the aging triggers null circ_staff when that value is equal to the loan user. The upgrade path for circulations that are already aged won't be able to be that precise, but can check on the renewal flags.

In the short term, yeah, not displaying the check out staff value for OPAC and auto-renewals makes sense.

Upon reviewing the code, we'll also need to do the same thing for the checkin_staff column, as that also gets set to the patron during OPAC and auto renewals.

Noting that not setting circ_staff and checkin_staff at all prior to a loan being aged could break reporting.

I also double-checked the aging of hold requests and there doesn't seem to be a parallel issue there, as action.hold_request.requestor is explicitly not retained during aging.