Comment 35 for bug 1993823

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Bill!

I'm personally in favor of squashing all `ng lint --fix` runs into the relevant substantive commits, rather than having them sprinkled in between runs of feature commits. Unless I'm off base there, my preference and intention would be to squash that one, and minor (in terms of lines of code) fixes, into the main body. Do you have any objections to my squashing those down, Bill?

As for "===", since we still live in a partially weakly-typed world, those still make me nervous. Maybe I just need to learn to love the bomb, though.

I'm also quite comfortable leaving lint complaints for later, especially if they are semantically fine and just make the linter sad.

Proposed commit plan: I'd like to fold your four commits into the main one (927d366b760e on your branch) and add a Co-authored-by for you. If that sounds good, then, here's a branch like that: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1993823-angular-reports-linted-squashed-signedoff