Comment 34 for bug 1993823

Thanks, Mike. This is all very close and looking great.

I've pushed another branch atop the rebased branch, with a few additions:

* Sign-offs
* Cleanup some minor console errors
* Fix an issue where creating a report + schedule in the same action failed.
* ng lint --fix
* A collection of manual ng lint repairs (mostly "===" and mixed tabs).

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1993823-angular-reports

There remains quite a few lint errors that are less trivial to resolve, however. Some will require a bit of refactoring. I was hesitant to dig into those.

Regarding linting, given the fast-approaching feature freeze and the relative newness of some of the more strict lint regulations, I'm personally open to the idea of resolving some of the lint issues post-merge if necessary, but didn't want to make that call unilaterally.