Thank you all for your feedback!
You will find an updated branch at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1993823-angular-reporter-20240417-PR that (I believe) addresses all of the code-related issues raised. It's also rebased and squashed, with one additional commit at the top that adds a redirect from the old UI's web client wrapper to the new implementation.
Thank you all for your feedback!
You will find an updated branch at https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ miker/lp- 1993823- angular- reporter- 20240417- PR that (I believe) addresses all of the code-related issues raised. It's also rebased and squashed, with one additional commit at the top that adds a redirect from the old UI's web client wrapper to the new implementation.