SIP Patron Status Too Many Charged and Lost Fields Never Set

[Jason Stephenson]

Evergreen SIP never sets the "too many itmes charged" and "too many items lost" fields in the Patron Status field in a SIP 64 Patron Information response. This information is available to the SIP software, so we should set these fields when appropriate.

This has actually tripped up one vendor who was expecting at least one of these field to be set on a blocked patron who exceeded the lost item count.

Additionally, the too many overdue items check only looks for the PATRON_EXCEEDS_OVERDUDE_COUNT penalty. The equivalent penalty for long overdue items should be includded in this check as well.

[Jason Stephenson (jstephenson)]

Here's a branch with 1 commit to reslove this issue. It adds 3 constants for penalties to the Const.pm module and then checks for these in the appropriate functions of the SIP Patron module.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1980978-sip-patron-status-improvement

[Jason Stephenson (jstephenson)]

C/W MARS has been using this code in production for over a year.

[Josh Stompro (u-launchpad-stompro-org)]

Tested this feature, and it seems to work correctly.

Rebased to master and working signoff branch at user/stompro/lp1980978-sip-patron-status-improvement-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1980978-sip-patron-status-improvement-signoff

I added a release note tag to the commit message also.

Testing Notes:

01234567890123
YYYY YY YYY <-- All related penalties set
YYYY Y YYY <-- Removed Exceeds checkout count (05 unset)
YYYY Y YY <-- Removed EXCEEDS_LOST_COUNT (09 unset)
YYYY Y YY <-- Removed Patron Exceeds Lost , but still has Patron Exceeds Longoverdue (No change)
YYYY YY <-- Removed Patron Exceeds LONGOVERDUE Count (06 unset)
YYYY Y YY <-- Applied PATRON_EXCEEDS_CHECKOUT_COUNT (05 set)
YYYY Y YYY <-- Applied PATRON_EXCEEDS_LOST_COUNT (9
YYYY YY YYY <-- Applied PATRON_EXCEEDS_LONGOVERDUE_COUNT

patron status 14-char, fixed-length field. This field is described in the preliminary NISO standard Z39.70-
199x. A Y in any position indicates that the condition is true. A blank (code $20) in this position
means that this condition is not true. For example, the first position of this field corresponds to
"charge privileges denied" and must therefore contain a code $20 if this patron’s privileges are
authorized.
Position Definition
0 charge privileges denied
1 renewal privileges denied
2 recall privileges denied
3 hold privileges denied
4 card reported lost
5 too many items charged
6 too many items overdue
7 too many renewals
8 too many claims of items returned
9 too many items lost
10 excessive outstanding fines
11 excessive outstanding fees
12 recall overdue
13 too many items billed