Comment 13 for bug 1970946

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Steven, I played around with this yesterday, and it mostly does the thing! However, the logic around false and null isn't quite there yet. When I toggle the pref, the highlighting works as expected in the staff search results, but then if I return to the prefs screen, the checkbox is always selected no matter what. The OPAC isn't mirroring what's been chosen in the staff preferences; it seems to behave independently.

Can you give this another look?

The form labels for the two checkbox preferences have gotten a little jumbled somehow. I've added a tiny commit to clean those up, if you'd like to squash this into your work: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1970946-Staff_Catalog_Disable_Highlight_Setting-label-fixup