Comment 5 for bug 1965447

I have tested Terran's proposed fix on her test server.

Note: for testing purposes, I added a number of item tag types and item tags owned at the system and branch levels.

Steps followed:

I logged in as a BR1 user
In the holdings editor, I selected "Item tags"
Only tag types owned by BR1 and its ancestors (SYS2, CONS) were displayed

I selected an item tag type owned by CONS (Digital Bookplate)
Only item tags associated with this tag type and owned by BR1 and its ancestors (CONS, SYS1) were displayed
I selected an item tag from the menu
I selected "Add Tag" and "Apply Changes"
I saved the item and exited
The item tag displayed correctly in the Patron OPAC View
Note: tags display twice in the Bootstrap catalog. I am not sure if that is the intended behavior. See https://terran-testbox.gapines.org/eg/opac/record/33 as an example

Next, I logged in as BR4 user
In the holdings editor, I selected "Item Tags"
Again, only the appropriate tag types (e.g. those owned by BR4, SYS2 and CONS) displayed on the dropdown menu

I selected an item tag type owned by BR4 (BR4 Grants)
Only item tags associated with this tag type and owned by BR4 were displayed
I chose an item tag from the menu
I selected "Add Tag" and "Apply Changes"
Apply all, Save, and Exit
The tag displayed correctly in the Patron OPAC View

Note: in order to create new item tag types and item tags, I added the needed permissions for a BR1 user (br1bbrown). Using this login I was able to create an item tag and to associate this tag with an item tag type owned by BR4. As noted above, in the holdings editor, only item tag types owned by the user's working location or its ancestors are displayed. However, I think the item tag type and item tag configuration interfaces may need some tweaking to prevent errors when adding or editing item tag types and item tags. This may warrant opening a new bug.