Evergreen

  1. Bug #1964986
  2. Comment #7

Comment 7 for bug 1964986

Revision history for this message
Galen Charlton (gmc) wrote : Re: Pull list can lose pagination when a patron has more than one penalty

This bug report as stated is now moot on all supported versions of Evergreen, as the Angular version of the pull list does not use the ahopl IDL class, nor is there any other active code that uses that class directly. I.e., this is a bug with the AngularJS pull list.

(Also, the proposed fix is insufficient: if a hold has multiple hold notes, as is done in Concerto for staff-placed holds, the open-ils.fielder call that the AngularJS pull lists invokes does a left join on action.hold_request_note. That throws off pagination and retrieval by the grid regardless of the "DISTINCT" in ahopl.)

It is possible that there are reports still using the ahopl/"Holds On Pull List" source. However, since Clark effectively dedupes all report query output, an extra "DISTINCT" in ahopl would have no effect.

Nonetheless, I've pushed this patch, as theoretically there could be local code still out there making direct PCRUD queries against ahopl. I've taken the liberty of editing the commit message, and will also open a bug to propose a deprecation of ahopl.