Cannot delete notes in holdings editor

[Elaine Hardy]

For ver. 3.8

Can no longer delete item notes from the holdings editor.

Workflow:

1.Click on Item notes button within the holdings editor.
2. Click Remove button
3. Click Apply changes. Note interface closes.
4. Click on Apply all, Save & Exit.

Editor closes but note still present

Note will delete using new Add/manage Item notes in the actions menu.

It is helpful to be able to remove the holdings editor if I am also making other changes or if I realize I added the not to the wrong copy.

[Mary Llewellyn (mllewell)]

The same can be said for item tags.

[Galen Charlton (gmc)]

A patch for the item notes bug is available at the tip of user/gmcharlt/lp1955065_fix_item_note_deletion / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1955065_fix_item_note_deletion

[Galen Charlton (gmc)]

I've created bug 1981095 for the item tags issue.

[Bill Erickson (berick)]

Sign off and follow up patch pushed to accommodate some cases where the dialog was closed with no data or differently shaped data.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1955065-fix-item-note-delete

I'm unclear on one aspect of this bug, though, because item note deletion in the copy editor is only available when creating a new note, so it may be deleted before it's initially saved. There is no delete option otherwise.

From the original steps:
1. Click on Item notes button within the holdings editor.
2. Click Remove button

Here, I don't see a Remove button. What am I missing?

[Jennifer Pringle (jpringle-u)]

I see the Remove button beside both existing notes and new notes on the Item Notes pop-up.

[Bill Erickson (berick)]

Thanks, Jennifer. Looks like my fix for bug #1959716 caused the "mode" of the dialog to change in the copy editor. I'll push another fix to address that.

[Bill Erickson (berick)]

I pushed another commit to user/berick/lp1955065-fix-item-note-delete to fix the regression caused by my fix to bug #1959716. The issue affected copy notes and alerts.

At least now I can fully confirm the patches for this bug do the thing.

[Galen Charlton (gmc)]

Pushed to master, rel_3_9, and rel_3_8 along with Bill's follow-ups. Thanks, Bill!