Comment 5 for bug 1949243

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1949243-edi-ftx-lin-2 has an updated fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1949243-edi-ftx-lin-2

The fix consists of 2 commits. The first commit has the uncontroversial FTX fix. The second commit adds a new "LINEITEM_SEQUENTIAL_ID" EDI attribute which determines whether the line sequence number is sequential; when the new attribute is not applied, EG's internal lineitem ID will be used, so the existing behavior is unchanged by default. This commit also fixes the issue Galen noticed in comment #4.

My grasp of EDI is shaky and I'm not sure how to generate EDI output without sending it to a vendor, but I think a test plan would be something like this:

1. Set up an EDI account.
2. Create a PO that includes a lineitem note.
3. Generate EDI output. Verify that the FTX line is missing a field and the LIN line is using the lineitem ID.
4. Apply the fix.
5. Add the LINEITEM_SEQUENTIAL_ID attribute to your EDI account.
6. Generate EDI output. Verify that the FTX line is now correct and that the LIN line uses a sequential ID.
7. Remove the LINEITEM_SEQUENTIAL_ID attribute from your EDI account.
8. Generate EDI output. Verify that the LIN line is using the lineitem ID again.