Comment 3 for bug 1945498

Revision history for this message
Galen Charlton (gmc) wrote :

Some feedback:

[1] I'm seeing the following errors in the console:

NG0303: Can't bind to 'ngbDropdown' since it isn't a known property of 'div' (used in the 'StaffNavComponent' component template).
NG0303: Can't bind to 'ngbDropdownMenu' since it isn't a known property of 'div' (used in the 'StaffNavComponent' component template).
NG0303: Can't bind to 'ngbDropdownItem' since it isn't a known property of 'button' (used in the 'StaffNavComponent' component template).

I don't think it likes the "[ngbDropdown]", "[ngbDropdownMenu]", etc.

[2] This is a little artificial, but when you expand the viewport from cell phone size to something wider while one of the menus is open, the navbar doesn't fully convert back to the full-width version: the background color of the open menu doesn't change to white and the overall navbar height remains too high.

[3] On smaller viewports, if you've opened the menu, then select the home menu item to go to the splash page, the menu remains open.

[4] The patch no loner passes ng lint.